From: Christoph Hellwig <hch@lst.de>
Date: Fri, 25 Feb 2022 19:14:40 +0100
Subject: [PATCH] block: default BLOCK_LEGACY_AUTOLOAD to y
Git-commit: 451f0b6f4c44d7b649ae609157b114b71f6d7875
Patch-mainline: v5.18-rc1
References: jsc#PED-1183
As Luis reported, losetup currently doesn't properly create the loop
device without this if the device node already exists because old
scripts created it manually. So default to y for now and remove the
aggressive removal schedule.
Reported-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220225181440.1351591-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Hannes Reinecke <hare@suse.com>
---
block/Kconfig | 8 +++-----
block/bdev.c | 2 +-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/Kconfig b/block/Kconfig
index 168b873eb666..7eb5d6d53b3f 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -28,15 +28,13 @@ if BLOCK
config BLOCK_LEGACY_AUTOLOAD
bool "Legacy autoloading support"
+ default y
help
Enable loading modules and creating block device instances based on
accesses through their device special file. This is a historic Linux
feature and makes no sense in a udev world where device files are
- created on demand.
-
- Say N here unless booting or other functionality broke without it, in
- which case you should also send a report to your distribution and
- linux-block@vger.kernel.org.
+ created on demand, but scripts that manually create device nodes and
+ then call losetup might rely on this behavior.
config BLK_RQ_ALLOC_TIME
bool
diff --git a/block/bdev.c b/block/bdev.c
index c68772644566..a3632317c8aa 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
inode = ilookup(blockdev_superblock, dev);
if (inode)
pr_warn_ratelimited(
-"block device autoloading is deprecated. It will be removed in Linux 5.19\n");
+"block device autoloading is deprecated and will be removed.\n");
}
if (!inode)
return NULL;
--
2.35.3