Blob Blame History Raw
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 25 Jun 2022 23:52:43 +0300
Subject: [PATCH] NFSD: restore EINVAL error translation in nfsd_commit()
Git-commit: 8a9ffb8c857c2c99403bd6483a5a005fed5c0773
Patch-mainline: v5.19
References: git-fixes

commit 555dbf1a9aac ("nfsd: Replace use of rwsem with errseq_t")
incidentally broke translation of -EINVAL to nfserr_notsupp.
The patch restores that.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 555dbf1a9aac ("nfsd: Replace use of rwsem with errseq_t")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-by: NeilBrown <neilb@suse.com>

---
 fs/nfsd/vfs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1175,14 +1175,15 @@ nfsd_commit(struct svc_rqst *rqstp, stru
 			nfsd_copy_boot_verifier(verf, nn);
 			err2 = filemap_check_wb_err(nf->nf_file->f_mapping,
 						    since);
+			err = nfserrno(err2);
 			break;
 		case -EINVAL:
 			err = nfserr_notsupp;
 			break;
 		default:
 			nfsd_reset_boot_verifier(nn);
+			err = nfserrno(err2);
 		}
-		err = nfserrno(err2);
 	} else
 		nfsd_copy_boot_verifier(verf, nn);