| From 7eb6ea4148579b85540a41d57bcec315b8af8ff8 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Thu, 12 Aug 2021 10:00:04 +0300 |
| Subject: [PATCH] PCI: Fix pci_dev_str_match_path() alloc while atomic bug |
| Git-commit: 7eb6ea4148579b85540a41d57bcec315b8af8ff8 |
| Patch-mainline: v5.15-rc1 |
| References: git-fixes stable-5.14.7 |
| |
| pci_dev_str_match_path() is often called with a spinlock held so the |
| allocation has to be atomic. The call tree is: |
| |
| pci_specified_resource_alignment() <-- takes spin_lock(); |
| pci_dev_str_match() |
| pci_dev_str_match_path() |
| |
| Fixes: 45db33709ccc ("PCI: Allow specifying devices using a base bus and path of devfns") |
| Link: https://lore.kernel.org/r/20210812070004.GC31863@kili |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> |
| Reviewed-by: Logan Gunthorpe <logang@deltatee.com> |
| Acked-by: Takashi Iwai <tiwai@suse.de> |
| |
| |
| drivers/pci/pci.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c |
| index aacf575c15cf..9a6513ffdef1 100644 |
| |
| |
| @@ -265,7 +265,7 @@ static int pci_dev_str_match_path(struct pci_dev *dev, const char *path, |
| |
| *endptr = strchrnul(path, ';'); |
| |
| - wpath = kmemdup_nul(path, *endptr - path, GFP_KERNEL); |
| + wpath = kmemdup_nul(path, *endptr - path, GFP_ATOMIC); |
| if (!wpath) |
| return -ENOMEM; |
| |
| -- |
| 2.26.2 |
| |