| From 43f2517955875be5d96b641fba33d73097fe3cd9 Mon Sep 17 00:00:00 2001 |
| From: Anitha Chrisanthus <anitha.chrisanthus@intel.com> |
| Date: Thu, 27 Jan 2022 10:45:46 -0800 |
| Subject: [PATCH] drm/kmb: Fix for build errors with Warray-bounds |
| Git-commit: 43f2517955875be5d96b641fba33d73097fe3cd9 |
| Patch-mainline: v5.17-rc3 |
| References: git-fixes |
| |
| This fixes the following build error |
| |
| Drivers/gpu/drm/kmb/kmb_plane.c: In function 'kmb_plane_atomic_disable': |
| drivers/gpu/drm/kmb/kmb_plane.c:165:34: error: array subscript 3 is above array bounds of 'struct layer_status[2]' [-Werror=array-bounds] |
| 165 | kmb->plane_status[plane_id].ctrl = |
| LCD_CTRL_GL2_ENABLE; |
| | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ |
| In file included from drivers/gpu/drm/kmb/kmb_plane.c:17: |
| drivers/gpu/drm/kmb/kmb_drv.h:61:41: note: while referencing 'plane_status' |
| 61 | struct layer_status plane_status[KMB_MAX_PLANES]; |
| | ^~~~~~~~~~~~ |
| drivers/gpu/drm/kmb/kmb_plane.c:162:34: error: array subscript 2 is above array bounds of 'struct layer_status[2]' [-Werror=array-bounds] |
| 162 | kmb->plane_status[plane_id].ctrl = LCD_CTRL_GL1_ENABLE; |
| | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ |
| In file included from |
| drivers/gpu/drm/kmb/kmb_plane.c:17: |
| drivers/gpu/drm/kmb/kmb_drv.h:61:41: note: while referencing 'plane_status' |
| 61 | struct layer_status plane_status[KMB_MAX_PLANES]; |
| | |
| ^~~~~~~~~~~~ |
| |
| Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") |
| Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com> |
| Reviewed-by: Kees Cook <keescook@chromium.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20220127194227.2213608-1-anitha.chrisanthus@intel.com |
| Acked-by: Takashi Iwai <tiwai@suse.de> |
| |
| |
| drivers/gpu/drm/kmb/kmb_plane.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c |
| index 00404ba4126d..2735b8eb3537 100644 |
| |
| |
| @@ -158,12 +158,6 @@ static void kmb_plane_atomic_disable(struct drm_plane *plane, |
| case LAYER_1: |
| kmb->plane_status[plane_id].ctrl = LCD_CTRL_VL2_ENABLE; |
| break; |
| - case LAYER_2: |
| - kmb->plane_status[plane_id].ctrl = LCD_CTRL_GL1_ENABLE; |
| - break; |
| - case LAYER_3: |
| - kmb->plane_status[plane_id].ctrl = LCD_CTRL_GL2_ENABLE; |
| - break; |
| } |
| |
| kmb->plane_status[plane_id].disable = true; |
| -- |
| 2.31.1 |
| |