From: Hannes Reinecke <hare@suse.de>
Date: Wed, 25 Jan 2017 08:12:17 +0100
Subject: sd: always scan VPD pages if thin provisioning is enabled
References: bsc#1013792
Patch-Mainline: submitted linux-scsi 2017/01/25
For any device with an older SCSI revision we might not
be scanning VPD pages, which results in a wrongly configured
discard mode if thin provisioned is enabled.
According to sbc3 any thin provisioned device (ie devices which
have the LBPME bit set in the output of READ CAPACITY(16)) need
to support VPD pages. So this patch always enables VPD pages
even for older SCSI revisions if thin provisioning is enabled.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
drivers/scsi/sd.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3acf578..e7a9463 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2286,7 +2286,15 @@ static int read_capacity_16(struct scsi_disk *sdkp, struct scsi_device *sdp,
if (buffer[14] & 0x40) /* LBPRZ */
sdkp->lbprz = 1;
- sd_config_discard(sdkp, SD_LBP_WS16);
+ /*
+ * sbc3r36 states:
+ * The device server in a logical unit the supports
+ * logical block provisioning management shall support
+ * the Logical Block Provisioning VPD page.
+ * So VPD pages should be supported if lbpme is set.
+ */
+ if (!scsi_device_supports_vpd(sdp))
+ sdp->try_vpd_pages = 1;
}
sdkp->capacity = lba + 1;
--
1.8.5.6